UDPExporter should be useable when Application Signals is disabled on Lambda #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently, if AppSignals is disabled, UDP Span Exporter not usable in Lambda.
According to this comment, the correct logic should be:
Currently, this is not respected because when AppSignals is disabled, ADOT's otel config cannot use the UDPExporter
AppSignals enabledandAppSignals disabledconfigurations is that in the "disabled" case, ADOT leaves the Span Exporter/Processor and textMapPropagator initialization work to the OTel JS SDK. Only inAppSignals enabledscenario, the configured UDPExporter is accessible.Description of changes:
Update
configure()to not depend on AppSignalsEnabled flag (always use the Span Exporter/Processor and textMapPropagator configurations made from the ADOT configurator)Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.